The Picture effect looses one row at the top of all images.


The Picture effect has to draw images flipped in the Y axis and the offset calculation was not accounting for the zero based index and thus was off by one. This affects the regular Picture effect and the Fast Picture effect that was derived from it in the Lip-sync effect. 


Geoff Armstrong
December 10, 2018, 9:45 AM

I have never noticed it missing the bottom row before, I think that could be because I don't really have anything that would go to the edges.

I have looked at your branch and tested before and after with the picture and fast picture and it looks good.

Jeff Uchitjil
December 9, 2018, 3:21 PM

Geoff, I made this fix, but I know you probably use a lot more picture effects than I do. Can you give this some testing and make sure there are no ill effects I did not think of?



Jeff Uchitjil


Jeff Uchitjil

Fix Build Number